Skip to content

Remove deprecated MediaStreamErrorEvent#237

Merged
blink1073 merged 1 commit into
jupyterlab:masterfrom
afshin:media-stream-event
Sep 22, 2021
Merged

Remove deprecated MediaStreamErrorEvent#237
blink1073 merged 1 commit into
jupyterlab:masterfrom
afshin:media-stream-event

Conversation

@afshin

@afshin afshin commented Sep 22, 2021

Copy link
Copy Markdown
Member

Fixes #236
h/t @SnarkBoojum

@jupyterlab-probot

jupyterlab-probot Bot commented Sep 22, 2021

Copy link
Copy Markdown

Thanks for making a pull request to lumino!
To try out this branch on binder, follow this link: Binder

blink1073
blink1073 approved these changes Sep 22, 2021
View reviewed changes

@blink1073 blink1073 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 added the bug Something isn't working label Sep 22, 2021
@blink1073 blink1073 merged commit 6377a3e into jupyterlab:master Sep 22, 2021
@blink1073

blink1073 commented Sep 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Publishing a version of @lumino/widgets 1.19.x with this fix so we can use it in JupyterLab 3.1

@blink1073

blink1073 commented Sep 22, 2021

Copy link
Copy Markdown
Contributor 
 - @lumino/application => 1.16.1
 - @lumino/commands => 1.12.1
 - @lumino/datagrid => 0.20.1
 - @lumino/default-theme => 0.10.1
 - @lumino/virtualdom => 1.8.1
 - @lumino/widgets => 1.19.1

@blink1073 blink1073 mentioned this pull request Sep 22, 2021
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blink1073 blink1073 blink1073 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PATCH] MediaStreamErrorEvent removed from TypeScript from 4.4 onward

2 participants

@afshin @blink1073