Added PointerEvents to splitpanel#251
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
The code looks good to me, and it worked as expected on my iPad in the dockpanel example for this PR. Are you still seeing issues on your end @martaszmit? If so, what hardware are you using to test? |
|
Yes, I'm testing it on my laptop dell precision 7550 with touch screen in the dockpanel example. screen-capture.movIf it works fine for you when would be possible to merge it deliver new version of Lumino? Maybe after update in my project, it will work as expected. |
|
It could be that it is inconsistently generating the pointer events on your hardware. A way to check that would be to add a console log in |
|
Ok, I will check it today. |
|
Once we think this is ready, I can merge and release on the same day. I'm happy to merge as-is since it is already an improvement, and then you can follow up based on more testing on your hardware. |
|
I think would be great if it will be merged now, and I will test it, and go back to you if I will still have an issue with it, ok? |
|
Sounds good, releasing now. |
|
Thank you! |
|
It could be the combination of browser/OS on the Dell that is causing inconsistent |
|
Thank you for hints, I already found an oversight in my app :) Now works fine on iPad, but still doesn't work on my laptop. I tested my app and dockpanel example on few laptops and browsers using developer tools (because only my laptop has a touch screen). Could you also test dockpanel example using developer tools on your computer, please? I wonder if it will work fine for you. |
|
Interesting! I saw the same thing when I opened Developer Tools for my iPad. The drag-n-drop mostly works, but the events are sporadic (it selects the input box within the panel), and the split panel handles do not work. When I closed the Developer Tools, it returned to normal behavior. Mind opening a new issue to track this? |
|
I opened a bug ticket for this issue (#254). |
|
Thanks again @martaszmit! |
No description provided.