Fix resizing and mode switching in DockPanel#411
Merged
Conversation
DockPanelDockPanel
afshin
commented
Sep 15, 2022
fcollonval
approved these changes
Sep 15, 2022
fcollonval
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for digging this one up @afshin
Let's merge and I'll do an alpha release.
afshin
added a commit
to afshin/lumino
that referenced
this pull request
Sep 15, 2022
fcollonval
pushed a commit
that referenced
this pull request
Sep 15, 2022
* Follow-on to #411 * Un-deprecate `empty()` * Update API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
DockPanelsingle-documentandmultiple-documentinDockLayoutdocklayout.spec.tsfileThis came up in the Lumino Gitter channel:
https://gitter.im/jupyterlab/lumino?at=6321ba7faa091774290be83a