Keydown event at bubbling phase#635
Merged
Merged
Conversation
… the keydown event at bubbling phase
krassowski
reviewed
Sep 21, 2023
fcollonval
requested changes
Sep 21, 2023
fcollonval
left a comment
Member
There was a problem hiding this comment.
Thanks @brichet here are some suggestions
Contributor
Author
|
Thanks for your quick review @fcollonval @krassowski. |
fcollonval
approved these changes
Sep 22, 2023
fcollonval
left a comment
Member
There was a problem hiding this comment.
Thanks @brichet
@krassowski I would like to get a pre-release of lumino with this on Monday, is it ok for you?
Member
|
Sounds great, thank you! |
Member
|
Merging this and doing an alpha release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an experimental parameter when starting application to handle the keydown event at bubbling phase.
Currently the keydown events are handled at capture phase. With this PR it with possible to switch from capture to bubbling at startup.
See jupyterlab/jupyterlab#14115 (comment) for context.
cc. @fcollonval @krassowski @gabalafou