Skip to content

unsubscribe from grid wheel events on editor dispose#80

Merged
blink1073 merged 1 commit into
jupyterlab:masterfrom
mbektas:unsubscribe_grid_wheel
Jun 12, 2020
Merged

unsubscribe from grid wheel events on editor dispose#80
blink1073 merged 1 commit into
jupyterlab:masterfrom
mbektas:unsubscribe_grid_wheel

Conversation

@mbektas

@mbektas mbektas commented Jun 9, 2020

Copy link
Copy Markdown
Member

make sure cell editor unsubscribes from grid's wheel messages when editor is disposed

fixes #62

@blink1073 blink1073 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 87ddf3c into jupyterlab:master Jun 12, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cell editing using old model state when repainting, following a data model change

2 participants