Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

👈 Launch RetroLab on Binder

@jtpio unsure what's going on but this is still not working. I'll get back it sometime after the holiday week (in the states).

Test dockerfile and image:

https://github.com/jabbera/retrolab/blob/hub_docker/Dockerfile

jabberaa/retro:latest

Couldn't stay away.

hub-extension looks for a setting called hubPrefix in the paths that comes from the page config

I had to bring over these lines from JupyterLab to set the property

I'm unsure about resetting the token and this PR should be reviewed carefully but the menu item shows up and works.

Thanks @jabbera for investigating this 👍

I had to bring over these lines from JupyterLab to set the property

Maybe we'll also need to bring this logic to retrolab for now. Or maybe find a way to make it more reusable across lab-based applications.

I brought them over in this PR and it sorted the issue.

Great, thanks @jabbera.

Would you mind posting a quick screenshot in the top comment for reference? Thanks!

EDIT: done

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

@meeseeksdev please backport to 0.2.x

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout 0.2.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 0f7c026472e64b9f9073cce47a00c072d6a84af5

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #148: Enable hub-extension'

4. Push to a named branch :

git push YOURFORK 0.2.x:auto-backport-of-pr-148-on-0.2.x

5. Create a PR against branch 0.2.x, I would have named this PR:

"Backport PR #148 on branch 0.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.