Add an 'interface switcher' to the toolbar by yuvipanda · Pull Request #158 · jupyterlab/retrolab

yuvipanda · 2021-06-08T21:10:08Z

Fixes #157

Is how it looks. Can switch to lab or classic.

welcome · 2021-06-08T21:10:09Z

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

github-actions · 2021-06-08T21:10:24Z

👈 Launch RetroLab on Binder

yuvipanda · 2021-06-08T21:13:10Z

I also wonder if we should trigger a save of the notebook first? Otherwise you might end up not seeing the proper notebook

jtpio · 2021-06-09T10:09:07Z

Thanks!

We still depend on nbclassic at the moment:

retrolab/setup.py

Line 90 in 0f7c026

"nbclassic~=0.2",

So there could indeed be an interface switcher like this in the notebook toolbar.

I also wonder if we should trigger a save of the notebook first? Otherwise you might end up not seeing the proper notebook

Sounds good 👍

jtpio · 2021-06-09T10:11:44Z

Also I'm wondering whether this plugin could actually go in the lab extension package?

https://github.com/jupyterlab/retrolab/blob/main/packages/lab-extension/src/index.ts

Then it would also be available in the JupyterLab UI:

We could then remove the existing RetroLab icon from the notebook toolbar, since this would already be covered by the switch?

yuvipanda · 2021-06-09T10:14:47Z

@jtpio so if we move it to the labextension, we'll have to determine current setup (lab or retro) and adjust choices accordingly. That seems reasonable, I'll do that instead.

jtpio · 2021-06-09T16:12:04Z

We could yes, by checking whether there is an IRetroShell or ILabShell (by having them in optional in the plugin).

It would also be fine to have them all show up in both retro and lab to start with.

yuvipanda · 2021-06-10T19:17:12Z

@jtpio I can't seem to figure out how to test this in lab though :(

yuvipanda · 2021-06-10T21:52:19Z

I did refactor the code to suck less, and theoretically added code to behave differently when running in lab vs retro. Any idea how I can test it?

jtpio · 2021-06-11T09:00:39Z

    require('@retrolab/docmanager-extension'),
    require('@retrolab/help-extension'),
    require('@retrolab/notebook-extension'),
+    require('@retrolab/lab-extension').default.filter(({ id }) =>


The lab-extension package is a "normal" JupyterLab 3.0 prebuilt extension:

retrolab/setup.py

Lines 28 to 41 in 752e21f

labext_name = "@retrolab/lab-extension"

lab_extension_dest = os.path.join(HERE, PACKAGE_NAME, "labextension")

lab_extension_source = os.path.join(HERE, "packages", "lab-extension")

# Representative files that should exist after a successful build

jstargets = [

os.path.join(lab_extension_dest, "package.json"),

os.path.join(main_bundle_dest, "bundle.js"),

]

package_data_spec = {PACKAGE_NAME: ["*", "templates/*", "static/**"]}

data_files_spec = [

("share/jupyter/labextensions/%s" % labext_name, lab_extension_dest, "**"),

So having the interface switcher in that package sounded like it would then be loaded automatically in both retro and lab, since retro also supports loading existing prebuilt JupyterLab extensions.

In that case we shouldn't need to manually include the package in this index.js file.

jtpio · 2021-06-11T09:03:49Z

+        commandLabel: 'Open in RetroLab',
+        dropdownLabel: 'RetroLab',
+        urlPrefix: `${baseUrl}retro/tree/`,
+        current: app.name === 'RetroLab'


Maybe we could also add ILabShell and IRetroShell as optional dependencies for the plugin, and check whether they are null to know if the current interface is a JupyterLab-like or RetroLab-like interface?

name could indeed be overriden via the page config or directly in JS like here:

https://github.com/jtpio/jupyterlite/blob/a198d902908483f8eea36fecae858cbd14b4a078/app/lab/index.template.js#L176

jtpio · 2021-06-11T09:08:53Z

Thanks Yuvi for the update 👍

Since the lab-extension package is a prebuild extension for JupyerLab, it should normally be loaded automatically in both interfaces.

For real testing, it would be great to start using end-to-end tools like Galata at some point: #135

yuvipanda · 2021-06-11T13:13:02Z

Ah, I'll make these changes :) And to clarify, when I said 'I do not know how to test these' I was refering to not being able to get JupyterLab to reflect my changes at all! So I can't actually see if what I did worked...

jtpio · 2021-06-11T13:36:04Z

It seems to be showing fine in both retro and lab now when testing with the Binder link above:

Although choosing one of the dropdown options doesn't seem to perform the switch.

Need to check, but maybe you need to run python -m pip install -e . every time for the changes to the lab extension to take effect locally. If so then we should definitely improve that workflow and use the jupyter labextension develop command.

yuvipanda · 2021-06-11T16:21:22Z

@jtpio yay, running pip install -e . worked. The idea is that instead of saying 'Interface' it will show the current interface by default, and selecting another will switch to that.

I'll change the way to detect which UI we are running by using ILabShell instead of the .name

yuvipanda · 2021-06-21T10:26:58Z

@jtpio gentle bump - anything else needed here?

jtpio · 2021-06-22T08:11:16Z

Thanks Yuvi for the update.

Checking with the Binder link above, it looks like choosing other interfaces has no effect?

interface-switch-binder.mp4

And it seems to be defaulting to JupyterLab.

jtpio · 2021-06-22T08:13:35Z

But using the commands from the command palette works fine.

yuvipanda · 2021-06-22T17:24:19Z

oh interesting - it works for me. I'll investigate it this week.

Fixes jupyterlab#157

Works on retrolab but can't get it to work on JupyterLab

It's automatically loaded by retrolab, since it's a labextension!

jtpio · 2021-09-03T10:27:33Z

@yuvipanda I pushed an update in 3f49eea to show the appropriate notebook toolbar buttons depending on the current interface:

interface-switch-buttons.mp4

Using buttons instead of a dropdown to help simplify the state management.

If you want to try it on Binder:

https://mybinder.org/v2/gh/yuvipanda/retrolab/open-in?urlpath=retro/tree

If it looks good to you we can merge and ship it right after in 0.3.4.

yuvipanda · 2021-09-03T11:22:05Z

Awesome! This looks great to me, thank you for putting effort into it!!!

jtpio · 2021-09-03T12:25:15Z

Great, thanks for checking it out!

Let's get it in then, I'll cut 0.3.4 right after.

jtpio · 2021-09-03T13:10:34Z

https://pypi.org/project/retrolab/0.3.4/

jtpio reviewed Jun 11, 2021

View reviewed changes

Comment thread app/index.js Outdated

yuvipanda force-pushed the open-in branch from 73b3760 to 3bc1574 Compare June 14, 2021 21:48

jtpio added this to the 0.3.0 milestone Sep 1, 2021

jtpio added the enhancement New feature or request label Sep 3, 2021

yuvipanda added 5 commits September 3, 2021 10:13

Add an 'interface switcher' to the toolbar

ba8671a

Fixes jupyterlab#157

Try moving interface switching to JupyterLab extension

f8dd657

Works on retrolab but can't get it to work on JupyterLab

Refactor interface chooser code to not suck

135b497

Don't use app.name to find current shell

f66e3b8

Don't explicitly include labextension in retrolab

a396892

It's automatically loaded by retrolab, since it's a labextension!

jtpio force-pushed the open-in branch from 02061a4 to a396892 Compare September 3, 2021 08:14

Add buttons to switch to classic lab and retro

3f49eea

jtpio merged commit b9cba83 into jupyterlab:main Sep 3, 2021

yuvipanda mentioned this pull request Mar 7, 2022

move to jupyterlab toolforge/paws#133

Merged

yuvipanda mentioned this pull request Mar 16, 2022

Educational JupyterHub considerations for notebook v7 switch jupyter/notebook-team-compass#10

Closed

	labext_name = "@retrolab/lab-extension"
	lab_extension_dest = os.path.join(HERE, PACKAGE_NAME, "labextension")
	lab_extension_source = os.path.join(HERE, "packages", "lab-extension")

	# Representative files that should exist after a successful build
	jstargets = [
	os.path.join(lab_extension_dest, "package.json"),
	os.path.join(main_bundle_dest, "bundle.js"),
	]

	package_data_spec = {PACKAGE_NAME: ["", "templates/", "static/**"]}

	data_files_spec = [
	("share/jupyter/labextensions/%s" % labext_name, lab_extension_dest, "**"),

Uh oh!

Conversation

yuvipanda commented Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

welcome Bot commented Jun 8, 2021

Uh oh!

github-actions Bot commented Jun 8, 2021

Uh oh!

yuvipanda commented Jun 8, 2021

Uh oh!

jtpio commented Jun 9, 2021

Uh oh!

jtpio commented Jun 9, 2021

Uh oh!

yuvipanda commented Jun 9, 2021

Uh oh!

jtpio commented Jun 9, 2021

Uh oh!

yuvipanda commented Jun 10, 2021

Uh oh!

yuvipanda commented Jun 10, 2021

Uh oh!

jtpio Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

jtpio Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

jtpio Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

jtpio commented Jun 11, 2021

Uh oh!

Uh oh!

yuvipanda commented Jun 11, 2021

Uh oh!

jtpio commented Jun 11, 2021

Uh oh!

yuvipanda commented Jun 11, 2021

Uh oh!

yuvipanda commented Jun 21, 2021

Uh oh!

jtpio commented Jun 22, 2021

Uh oh!

jtpio commented Jun 22, 2021

Uh oh!

yuvipanda commented Jun 22, 2021

Uh oh!

jtpio commented Sep 3, 2021

Uh oh!

yuvipanda commented Sep 3, 2021

Uh oh!

jtpio commented Sep 3, 2021

Uh oh!

jtpio commented Sep 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yuvipanda commented Jun 8, 2021 •

edited

Loading