Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Fix support for RTC #194

Merged
jtpio merged 2 commits into
jupyterlab:mainfrom
jtpio:yjs-resolutions
Aug 28, 2021
Merged

Fix support for RTC #194
jtpio merged 2 commits into
jupyterlab:mainfrom
jtpio:yjs-resolutions

Conversation

@jtpio

@jtpio jtpio commented Aug 27, 2021

Copy link
Copy Markdown
Member

Fixes #192

@github-actions

Copy link
Copy Markdown
Contributor

Binder 👈 Launch RetroLab on Binder

@jtpio jtpio added the enhancement New feature or request label Aug 27, 2021
@jtpio jtpio added this to the 0.3.0 milestone Aug 27, 2021
@jtpio

jtpio commented Aug 27, 2021

Copy link
Copy Markdown
Member Author

cc @fomightez if you want to try the change on the Binder link above.

This should fix RTC in RetroLab, including using a mix of lab and retro as interfaces (like the screenshot in #192 (comment))

image

@fomightez

Copy link
Copy Markdown

It works in Chrome wonderfully. Sweet. (Not the same computer I was testing on earlier, but it seems there was indeed an issue beyond that network.)

@jtpio

jtpio commented Aug 28, 2021

Copy link
Copy Markdown
Member Author

Nice, thanks @fomightez for checking.

@jtpio jtpio marked this pull request as ready for review August 28, 2021 09:37
@jtpio jtpio merged commit 660066f into jupyterlab:main Aug 28, 2021
@jtpio jtpio deleted the yjs-resolutions branch August 28, 2021 09:38
@jtpio

jtpio commented Aug 28, 2021

Copy link
Copy Markdown
Member Author

Gonna cut 0.3.1 with this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collaborative editing between RetroLab interfaces (and maybe between RetroLab & JupyterLab)

2 participants