Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Bump playwright version in package.json#304

Merged
jtpio merged 1 commit into
jupyterlab:mainfrom
gabalafou:update-playwright-for-mac
Dec 16, 2021
Merged

Bump playwright version in package.json#304
jtpio merged 1 commit into
jupyterlab:mainfrom
gabalafou:update-playwright-for-mac

Conversation

@gabalafou

@gabalafou gabalafou commented Dec 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

When I tried to install retrolab on my mac, I got an error message that said

Error: ERROR: Playwright does not support chromium on mac12

(longer log in comment below)

Upgrading the version of Playwright specified in package.json fixed the issue for me and I was able to install without a problem.

@welcome

welcome Bot commented Dec 16, 2021

Copy link
Copy Markdown

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions

github-actions Bot commented Dec 16, 2021

Copy link
Copy Markdown
Contributor

Binder 👈 Launch a Binder on branch gabalafou/retrolab/update-playwright-for-mac

@gabalafou

gabalafou commented Dec 16, 2021

Copy link
Copy Markdown
Contributor Author

Here's a longer excerpt of my install log after running pip install -e .:

Installing collected packages: retrolab
  Attempting uninstall: retrolab
    Found existing installation: retrolab 0.3.13
    Uninstalling retrolab-0.3.13:
      Successfully uninstalled retrolab-0.3.13
  Running setup.py develop for retrolab
    ERROR: Command errored out with exit status 1:
     command: /usr/local/Caskroom/miniforge/base/envs/retrolab/bin/python3.10 -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/gabriel/dev/retrolab/setup.py'"'"'; __file__='"'"'/Users/gabriel/dev/retrolab/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
         cwd: /Users/gabriel/dev/retrolab/
    Complete output (99 lines):
    running develop
    /private/var/folders/_j/9dxrg_n97gx6934c87_58pgr0000gp/T/pip-build-env-gf9dxj5v/overlay/lib/python3.10/site-packages/setuptools/command/easy_install.py:156: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
      warnings.warn(
    /private/var/folders/_j/9dxrg_n97gx6934c87_58pgr0000gp/T/pip-build-env-gf9dxj5v/overlay/lib/python3.10/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
      warnings.warn(
    running egg_info
    writing retrolab.egg-info/PKG-INFO
    writing dependency_links to retrolab.egg-info/dependency_links.txt
    writing entry points to retrolab.egg-info/entry_points.txt
    writing requirements to retrolab.egg-info/requires.txt
    writing top-level names to retrolab.egg-info/top_level.txt
    reading manifest file 'retrolab.egg-info/SOURCES.txt'
    reading manifest template 'MANIFEST.in'
    warning: no files found matching 'jupyter-config/retrolab.json'
    warning: no files found matching 'install.json'
    warning: no directories found matching 'src'
    warning: no directories found matching 'style'
    no previously-included directories found matching '**/node_modules'
    no previously-included directories found matching 'lib'
    warning: no previously-included files matching '*~' found anywhere in distribution
    warning: no previously-included files matching '*.pyc' found anywhere in distribution
    warning: no previously-included files matching '*.pyo' found anywhere in distribution
    warning: no previously-included files matching '.git' found anywhere in distribution
    warning: no previously-included files matching '.ipynb_checkpoints' found anywhere in distribution
    adding license file 'LICENSE'
    writing manifest file 'retrolab.egg-info/SOURCES.txt'
    running build_ext
    Creating /usr/local/Caskroom/miniforge/base/envs/retrolab/lib/python3.10/site-packages/retrolab.egg-link (link to .)
    Adding retrolab 0.3.13 to easy-install.pth file
    Installing jupyter-retro script to /usr/local/Caskroom/miniforge/base/envs/retrolab/bin
    
    Installed /Users/gabriel/dev/retrolab
    running post_develop
    Installing build dependencies with npm.  This may take a while...
    > jlpm install
    yarn install v1.21.1
    [1/4] Resolving packages...
    [2/4] Fetching packages...
    [3/4] Linking dependencies...
    warning "@jupyterlab/buildutils > verdaccio > clipanion@3.0.0-rc.12" has unmet peer dependency "typanion@*".
    warning "lerna > @lerna/version > @lerna/github-client > @octokit/rest > @octokit/plugin-request-log@1.0.3" has unmet peer dependency "@octokit/core@>=3".
    warning "workspace-aggregator-8719df58-3bb3-4fa6-8a66-2d15ac7d6ecb > @retrolab/app > mini-css-extract-plugin@0.9.0" has incorrect peer dependency "webpack@^4.4.0".
    warning "workspace-aggregator-8719df58-3bb3-4fa6-8a66-2d15ac7d6ecb > @retrolab/app > style-loader@1.0.2" has incorrect peer dependency "webpack@^4.0.0".
    warning "workspace-aggregator-8719df58-3bb3-4fa6-8a66-2d15ac7d6ecb > @retrolab/application > @jupyterlab/ui-components@3.2.0" has unmet peer dependency "react@^17.0.1".
    warning "workspace-aggregator-8719df58-3bb3-4fa6-8a66-2d15ac7d6ecb > @retrolab/ui-components > babel-loader@8.2.2" has unmet peer dependency "webpack@>=2".
    warning "workspace-aggregator-8719df58-3bb3-4fa6-8a66-2d15ac7d6ecb > @retrolab/app > @jupyterlab/json-extension > react-highlighter@0.4.3" has incorrect peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.0".
    warning "workspace-aggregator-8719df58-3bb3-4fa6-8a66-2d15ac7d6ecb > @retrolab/app > @jupyterlab/json-extension > react-json-tree@0.15.0" has unmet peer dependency "@types/react@^16.3.0 || ^17.0.0".
    warning "workspace-aggregator-8719df58-3bb3-4fa6-8a66-2d15ac7d6ecb > @retrolab/application-extension > @jupyterlab/codemirror > y-codemirror@2.1.1" has unmet peer dependency "yjs@^13.0.0".
    warning Workspaces can only be enabled in private projects.
    warning Workspaces can only be enabled in private projects.
    [4/4] Building fresh packages...
    error /Users/gabriel/dev/retrolab/node_modules/playwright: Command failed.
    Exit code: 1
    Command: node install.js
    Arguments:
    Directory: /Users/gabriel/dev/retrolab/node_modules/playwright
    Output:
    /Users/gabriel/dev/retrolab/node_modules/playwright/lib/install/installer.js:124
                throw new Error(`Failed to download ${browserName}, caused by\n${e.stack}`);
                      ^
    
    Error: Failed to download chromium, caused by
    Error: ERROR: Playwright does not support chromium on mac12
        at Object.assert (/Users/gabriel/dev/retrolab/node_modules/playwright/lib/utils/utils.js:194:15)
        at Registry.downloadURL (/Users/gabriel/dev/retrolab/node_modules/playwright/lib/utils/registry.js:346:17)
        at Object.downloadBrowserWithProgressBar (/Users/gabriel/dev/retrolab/node_modules/playwright/lib/install/browserFetcher.js:56:26)
        at async validateCache (/Users/gabriel/dev/retrolab/node_modules/playwright/lib/install/installer.js:123:9)
        at async installBrowsersWithProgressBar (/Users/gabriel/dev/retrolab/node_modules/playwright/lib/install/installer.js:74:9)
        at /Users/gabriel/dev/retrolab/node_modules/playwright/lib/install/installer.js:124:19
        at async validateCache (/Users/gabriel/dev/retrolab/node_modules/playwright/lib/install/installer.js:123:9)
        at async installBrowsersWithProgressBar (/Users/gabriel/dev/retrolab/node_modules/playwright/lib/install/installer.js:74:9)
    info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/Users/gabriel/dev/retrolab/setup.py", line 53, in <module>
        setuptools.setup(**setup_args)
      File "/private/var/folders/_j/9dxrg_n97gx6934c87_58pgr0000gp/T/pip-build-env-gf9dxj5v/overlay/lib/python3.10/site-packages/setuptools/__init__.py", line 153, in setup
        return distutils.core.setup(**attrs)
      File "/usr/local/Caskroom/miniforge/base/envs/retrolab/lib/python3.10/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/usr/local/Caskroom/miniforge/base/envs/retrolab/lib/python3.10/distutils/dist.py", line 966, in run_commands
        self.run_command(cmd)
      File "/usr/local/Caskroom/miniforge/base/envs/retrolab/lib/python3.10/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/private/var/folders/_j/9dxrg_n97gx6934c87_58pgr0000gp/T/pip-build-env-gf9dxj5v/overlay/lib/python3.10/site-packages/jupyter_packaging/setupbase.py", line 136, in run
        self.run_command(post_build.__name__)
      File "/usr/local/Caskroom/miniforge/base/envs/retrolab/lib/python3.10/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/usr/local/Caskroom/miniforge/base/envs/retrolab/lib/python3.10/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/private/var/folders/_j/9dxrg_n97gx6934c87_58pgr0000gp/T/pip-build-env-gf9dxj5v/overlay/lib/python3.10/site-packages/jupyter_packaging/setupbase.py", line 112, in run
        func()
      File "/private/var/folders/_j/9dxrg_n97gx6934c87_58pgr0000gp/T/pip-build-env-gf9dxj5v/overlay/lib/python3.10/site-packages/jupyter_packaging/setupbase.py", line 212, in builder
        run(npm_cmd + ['install'], cwd=node_package)
      File "/private/var/folders/_j/9dxrg_n97gx6934c87_58pgr0000gp/T/pip-build-env-gf9dxj5v/overlay/lib/python3.10/site-packages/jupyter_packaging/setupbase.py", line 275, in run
        return subprocess.check_call(cmd, **kwargs)
      File "/usr/local/Caskroom/miniforge/base/envs/retrolab/lib/python3.10/subprocess.py", line 369, in check_call
        raise CalledProcessError(retcode, cmd)
    subprocess.CalledProcessError: Command '['/private/var/folders/_j/9dxrg_n97gx6934c87_58pgr0000gp/T/pip-build-env-gf9dxj5v/overlay/bin/jlpm', 'install']' returned non-zero exit status 1.
    ----------------------------------------
  Rolling back uninstall of retrolab

@gabalafou

gabalafou commented Dec 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think this is maybe the relevant commit to Playwright that was added in version 1.13.0.

I can confirm that v1.13.0 is the first version in which the bug I describe above goes away. I confirmed by setting playwright=^1.13.0 in package.json, then running pip install.

Cross-referencing microsoft/playwright#7555

@jtpio jtpio added this to the 0.3.x milestone Dec 16, 2021
@jtpio

jtpio commented Dec 16, 2021

Copy link
Copy Markdown
Member

Thanks @gabalafou for this and the cross-references!

@jtpio jtpio merged commit 1ad349a into jupyterlab:main Dec 16, 2021
@welcome

welcome Bot commented Dec 16, 2021

Copy link
Copy Markdown

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@jtpio jtpio mentioned this pull request Dec 17, 2021
Merged
@VasuBhog VasuBhog mentioned this pull request Jan 6, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jtpio jtpio jtpio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

0.3.x

Development

Successfully merging this pull request may close these issues.

2 participants

@gabalafou @jtpio