update httpx requirement from >=0.25,<0.28 to >=0.25,<0.29 #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add REST API example in Programmatic use section
* updated settings to add test specific parameters * updated httpx package pinning to allow newer versions * fixed pyodbc package name to pass poetry check
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 35.76% 37.02% +1.26%
==========================================
Files 25 25
Lines 1071 1083 +12
==========================================
+ Hits 383 401 +18
+ Misses 688 682 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* move wsdl version to a config property
Contributor
Author
|
@iloveitaly please review |
iloveitaly
reviewed
Oct 17, 2025
| "poetry.lock": true | ||
| } | ||
| }, | ||
| "python.testing.pytestArgs": [ |
Collaborator
There was a problem hiding this comment.
unrelated, remove please
iloveitaly
reviewed
Oct 17, 2025
|
|
||
| class NetSuiteSoapApi: | ||
| version = "2021.1.0" | ||
| version = getattr(Config, "wsdl_version", "2024.2.0") |
Collaborator
There was a problem hiding this comment.
let's not update the default.
iloveitaly
reviewed
Oct 17, 2025
|
|
||
| @property | ||
| def wsdl_version(self) -> str: | ||
| return "2024.2.0" |
Collaborator
There was a problem hiding this comment.
if we are adding this, why do we need the default above?
iloveitaly
requested changes
Oct 17, 2025
| orjson = ["orjson"] | ||
| # TODO doesn't --all-extras solve this for us? | ||
| all = ["zeep", "ipython", "orjson", "odbc"] | ||
| all = ["zeep", "ipython", "orjson", "pyodbc"] |
Collaborator
There was a problem hiding this comment.
this is a big change, can we scope this change to the PR title?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would address the httpx package pinning to allow using the latest minor version.
Also update the settings file to make testing easier.
Finally, update the pyodbc package name to resolve a failure of 'poetry check'