Skip to content

Add Rust support. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2016
Merged

Add Rust support. #57

merged 1 commit into from
Jul 5, 2016

Conversation

@meqif
Copy link
Contributor

@meqif meqif commented Jul 5, 2016

Hi!

This pull request adds support for Rust files and would close #35.

I apologise in advance for some of the hairier regular expressions. If someone could suggest more efficient or cleaner alternatives, I would be grateful. If not, that's also okay.

@coveralls
Copy link

coveralls commented Jul 5, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling f90ed11 on meqif:rust-support into 7e25680 on jacktasia:master.

@coveralls
Copy link

coveralls commented Jul 5, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling f90ed11 on meqif:rust-support into 7e25680 on jacktasia:master.

@jacktasia
Copy link
Owner

jacktasia commented Jul 5, 2016

Awesome! Thanks for doing this. This looks good to me. Just give me a bit to try it out for real and then I'll merge it. Thanks again!

@meqif
Copy link
Contributor Author

meqif commented Jul 5, 2016

Thank you. 😄
I noticed a small mistake (a "test" instead of "JJJ" in a regular expression). I'll fix that in a jiffy and push a new squashed commit.

@coveralls
Copy link

coveralls commented Jul 5, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 87d5194 on meqif:rust-support into 7e25680 on jacktasia:master.

@meqif
Copy link
Contributor Author

meqif commented Jul 5, 2016

I see no more obvious mistakes and the commit was pushed, feel free to merge.

@jacktasia jacktasia merged commit 67f393e into jacktasia:master Jul 5, 2016
@meqif
Copy link
Contributor Author

meqif commented Jul 5, 2016

Awesome, thanks for merging!

@jacktasia
Copy link
Owner

jacktasia commented Jul 5, 2016

Of course! :shipit: Thanks again for adding Rust support. FWIW your changes should be available via MELPA in 3-12 hours.

@jacktasia jacktasia mentioned this pull request Jul 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add rustlang support

3 participants

@meqif @coveralls @jacktasia