Move jack_control command handlers to own functions #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This commit breaks python2 compatibility of jack_control While I like the intent, in LADI/jackdbus I'm playing conservative and keeping python2 compatibility, for its stable interface (even if it has other issues) and thus the non-deployability to python2 systems is a concern. |
Member
|
main jack2 doesnt care about python2, any recent enough distribution does not provide it as it is unmaintained by a very long time and is now a security risk. there was some initial work to move from waf to meson, which will help with this. |
Author
|
Hi all. We've moved away from JACK so I'm unlikely to work on this PR. Feel free to close. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to change as little as possible within the handlers. I've switched our setup to use this version so will be testing it.