Inconsistent method signature in pagination example #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11
commented
Oct 30, 2024
| * float minPrice, | ||
| * float maxPrice, | ||
| * PageRequest pageRequest, | ||
| * Order<Product> order); |
Member
Author
There was a problem hiding this comment.
FYI - Here is the example in the Javadoc that this is supposed to correspond to:
* page1 = products.findByNameLikeAndPriceBetween(
* namePattern, minPrice, maxPrice, page1Request,
* Order.by(Sort.desc("price"), Sort.asc("id"));
gavinking
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javadoc has a section about pagination which has an example method
that is supposed to be used for the following example usage pattern,
The two are inconsistent. The methods have different names and accept a different number of parameters.
This PR updates them to match so that the example will make more sense.