Fix config parsing issues #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when Protocol no specified in command line. Steps to reproduce: 1. echo 'protocol = "Wireguard"' > ~/.config/vopono/config.toml 2. vopono -v exec --provider None bash Result Error: None protocol must use None provider - will run not run any VPN service inside netns
No need to recreate file, which should be created manually. Calling with the --vopono-config option also caused the creation of a new config, but the owner and group of the file were root. In the end, this also this breaks this workflow: 1. Rename config.toml -> config.toml.bak 2. Rerun vopono 3. Revert renaming New behavior - empty config builder used if config file doesn't exists, without empty file creation.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix error, when Protocol in config ignored even when Protocol no specified in command line
Don't recreate config file if it doesn't exists
No need to recreate file, which should be created manually.
Don't error if default config doesn't exists, only make error if config specified as command line argument
Small docs fix