Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: janosmiko/lfk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.17.1
Choose a base ref
...
head repository: janosmiko/lfk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.17.2
Choose a head ref
  • 2 commits
  • 7 files changed
  • 1 contributor

Commits on Aug 15, 2026

  1. fix(test): make the suite pass the way packagers build it (#628) 

    * fix(test): make the suite pass the way packagers build it

TestUserAgent_NamesTheToolAndVersion asserted the "dev" default of
version.Version, but packagers inject a real version with -ldflags, so the
test could only pass for a plain `go build`. It now asserts the version that
is compiled in.

The e2e package held only build-tagged files, so an explicit `go test ./e2e`
failed with "build constraints exclude all Go files". `go test ./...` skipped
it silently, which is why CI never saw it. An untagged doc.go gives the
package one buildable file, so the command skips instead.

A new CI step runs the suite both ways to keep it that way.

Fixes #627

* fix(test): stop asserting the ldflags-injectable version defaults

The new CI step found the same bug two more times. TestFull_DefaultValues and
TestShort_DefaultValue asserted the compiled-in "dev" and "unknown", which a
packager overwrites with -ldflags.

Both now set the placeholders first, the way the sibling _Custom tests already
do, so they test the formatting instead of the build flags.
    @janosmiko
    janosmiko authored Aug 15, 2026
    Configuration menu
    Copy the full SHA
    4c49389 View commit details
    Browse the repository at this point in the history

  2. chore(main): release 0.17.2 (#629)

    @janosmiko
    janosmiko authored Aug 15, 2026
    Configuration menu
    Copy the full SHA
    0d83450 View commit details
    Browse the repository at this point in the history
Loading