fix: allow users to cancel mlx model download#7502
Merged
Conversation
Minh141120
approved these changes
Feb 10, 2026
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix cancellation of MLX model downloads by wiring MLX downloads into the same cancellation flows as other providers and ensuring the MLX extension can cancel active download tasks.
Changes:
- Update model download cancellation to attempt aborting both
llamacppandmlxengines. - Refactor MLX model download initiation to use
EngineManagerdirectly and adjust which HF repo files are queued. - Add MLX download task IDs + implement
abortImport()cancellation and cleanup in the MLX extension.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| web-app/src/services/models/default.ts | Attempts to abort downloads across both llamacpp and mlx engines and emits a stopped event. |
| web-app/src/containers/MlxModelDownloadAction.tsx | Adjusts MLX download flow (engine lookup, file selection, import invocation). |
| web-app/src/containers/DownloadManegement.tsx | Extends direct task cancellation condition to include mlx-prefixed IDs. |
| extensions/mlx-extension/src/index.ts | Adds MLX download task ID creation, implements abort/cancel behavior, and cleans up model folder on abort. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
Self Checklist