fix: resolve downloaded model toggle bug by handling developer prefix#7648
Merged
Conversation
Contributor
Author
|
The CONTRIBUTING.md mentions targeting |
Contributor
Author
|
After the fix, the downloaded model appears. However clicking the new chat button doesn't auto-select the correct model. Clicking on the model card doesn't show any variants as downloaded Let's me know if this need to be fixed in this PR as well. Cheers. |
louis-jan
previously approved these changes
Mar 7, 2026
louis-jan
left a comment
Contributor
There was a problem hiding this comment.
Thanks, I will do a check then merge
Contributor
|
@jamesdam it would be great to have model auto selected |
When clicking "new chat" from a downloaded model, use the actual downloaded model ID (with or without developer prefix) instead of just the variant.model_id. This ensures the model is correctly selected in the dropdown when the chat page loads.
Contributor
Author
|
@louis-jan thanks for reviewing. I attempted to fix the auto-select issue. It works for me locally, but hope you can take a deeper look too (I am very new to the codebase) |
louis-jan
approved these changes
Mar 8, 2026
Contributor
Contributor
|
@jamesdam @louis-jan the auto select model is works! Screen.Recording.2026-03-18.at.15.02.35.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fix the downloaded model toggle on the Hub page not showing downloaded models.
Root cause: The filter was comparing catalog variant IDs (without developer prefix) against downloaded model IDs (with developer prefix like
janhq/), causing all comparisons to fail.Fix: Updated the filter to check both direct match and with developer prefix, matching the pattern already used in
DownloadButton.tsx.Fixes Issues
Self Checklist