Code Review — first review

Summary

Adds a deterministic progress bar (completed / total) for file attachment ingestion in two places: ChatInput.tsx (paste/drop images + send-time processing) and ProjectFiles.tsx (batch file ingestion). Threads onIngestProgress callback through attachmentProcessing.ts.

Files changed: 18 | +174 / -47

Strengths

• Clean opt-in API: onIngestProgress is optional, so existing call sites are unaffected.
• finally blocks ensure progress state cleanup — no stuck progress bars on errors.
• Pre-counts ingestable items correctly, skipping already-processed files.
• Math.min(ingestCompleted, ingestTotal) guard prevents overflow.
• Full locale coverage across all 15 existing locales.
• Uses existing Radix Progress component — no new UI dependencies.

Issues

1. Redundant fallback string in ProjectFiles.tsx (inconsistency)

{t('common:projects.uploadingFiles') ?? 'Uploading files…'}

The ?? 'Uploading files…' is redundant since every locale has this key. ChatInput.tsx uses the key without a fallback. Pick one style and be consistent — recommend removing the fallback.

2. Inline-document fallthrough logic is non-obvious
When targetMode === 'inline' but parsedContent is undefined (parse failed), the code falls through to the embeddings path where bumpIngest() is also called. The count is exhausted correctly, but a comment would help future maintainers understand this is intentional.

3. Error path skips bumpIngest
When an image/document ingestion throws, bumpIngest for that item is never reached. The progress bar briefly appears "stuck" before the finally block cleans it up. Minor UX nit — acceptable but worth noting.

4. ProjectFiles.tsx vs ChatInput.tsx error recovery inconsistency
ChatInput continues processing remaining files after an individual failure; ProjectFiles propagates the error immediately and stops. This means a batch of 5 files where file 3 fails shows 2/5 then disappears in ProjectFiles, but would continue to 5/5 in ChatInput.

Recommendation: improve needed (minor)

Two small items before merge:

1. Remove the ?? 'Uploading files…' fallback in ProjectFiles.tsx (or add the same in ChatInput.tsx for consistency).
2. Add a brief inline comment in attachmentProcessing.ts near the if (targetMode === 'inline' && parsedContent) branch explaining the fallthrough logic.

Overall this is well-scoped, correct, and follows existing codebase patterns. Good work on the thorough locale coverage.

Follow-up Review — commit 6d63886

What changed

• Removes unnecessary null coalescing (?? 'Uploading files…') from a t() call — correct since i18next always returns a string.
• Adds clarifying comments in attachmentProcessing.ts explaining the embeddings-fallback path when inline parsing fails.

Both are minor cleanup items addressing previous review feedback.

Recommendation: can merge

Review feedback addressed. The progress bar feature is well-implemented with proper i18n support.