Skip to content

build: preparations for musl#61

Merged
javalsai merged 3 commits into
masterfrom
musl-build
Jul 16, 2025
Merged

build: preparations for musl#61
javalsai merged 3 commits into
masterfrom
musl-build

Conversation

@grialion

@grialion grialion commented Jul 9, 2025

Copy link
Copy Markdown
Collaborator

This PR makes it possible to build using musl libc. The application functionality not been tested yet. I won't test it myself, but it should work.

Fixes Void Linux package CI errors.

grialion added 2 commits July 9, 2025 23:07
Use standard sys/time.h instead of libc specific header bits/types/... for musl compatibility
Use standard pid_t type instead of libc specific __pid_t type.
@javalsai

javalsai commented Jul 9, 2025

Copy link
Copy Markdown
Owner

The application functionality not been tested yet

If it doesn't brake current builds no harm in compiling for musl too. If we are supposed to support musl I'd like to add some CI tests for that though.

@grialion

grialion commented Jul 9, 2025

Copy link
Copy Markdown
Collaborator Author

If it doesn't brake current builds no harm in compiling for musl too.

Builds on both compilers just fine, as you can see.

If we are supposed to support musl I'd like to add some CI tests for that though.

Exactly what I thought. It would pollute the released binaries quite a bit though. Maybe keep it for x86_64 and aarch64, but nothing else.

@javalsai

Copy link
Copy Markdown
Owner

That should be it, do you need a release to package this?

@grialion

Copy link
Copy Markdown
Collaborator Author

LGTM!

That should be it, do you need a release to package this?

No, the necessary patch is already there. I'm just waiting for an update from the maintainers. So making a release just for that won't help.

PS: don't we want to also include the musl binary in the release artifacts? If it gets merged into void packages it won't be used though.

@javalsai

Copy link
Copy Markdown
Owner

PS: don't we want to also include the musl binary in the release artifacts?

It should already happen, will appear on the next release.

@javalsai javalsai merged commit 6c99675 into master Jul 16, 2025
10 checks passed
@javalsai javalsai deleted the musl-build branch July 16, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants