Skip to content

misc batch of fixes before v1.2.3#65

Merged
javalsai merged 5 commits into
masterfrom
fixes
Jul 20, 2025
Merged

misc batch of fixes before v1.2.3#65
javalsai merged 5 commits into
masterfrom
fixes

Conversation

@javalsai

Copy link
Copy Markdown
Owner

No description provided.

@javalsai

Copy link
Copy Markdown
Owner Author
  • fix some formatter and linter issues
  • make clang-tidy/clang-format fail with error status and output in github error format
  • docs, add kmscon thing

@javalsai

javalsai commented Jul 16, 2025

Copy link
Copy Markdown
Owner Author

I'd also like to fix whatever is wrong with aarch64 builds

might just be

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 3b550e4..87e6fcd 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -66,9 +66,12 @@ jobs:
           install: |
             apt-get update && \
             apt-get install -y make gcc libpam0g-dev
-          run: ARCH=aarch64 GITHUB_STEP_SUMMARY=gss.out GITHUB_OUTPUT=go.out assets/github_scripts/build.sh
+          run: |
+            set +e
+            ARCH=aarch64 GITHUB_STEP_SUMMARY=gss.out GITHUB_OUTPUT=go.out assets/github_scripts/build.sh
+            echo "$?" > status.out
       - if: always()
-        run: set +e; cat gss.out >>"$GITHUB_STEP_SUMMARY"; cat go.out >>"$GITHUB_OUTPUT"
+        run: set +e; cat gss.out >>"$GITHUB_STEP_SUMMARY"; cat go.out >>"$GITHUB_OUTPUT"; exit "$(cat status.out)"
 
       - uses: actions/upload-artifact@v4
         with:

because I think the inside failure causes run-on-arch to not pass files out and then the always-run doesnt have access to those files

@javalsai

javalsai commented Jul 20, 2025

Copy link
Copy Markdown
Owner Author

idec, let aarch64 remain dead

@javalsai javalsai marked this pull request as ready for review July 20, 2025 19:48
@javalsai javalsai merged commit 8f0213d into master Jul 20, 2025
19 of 20 checks passed
@javalsai javalsai deleted the fixes branch July 20, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant