Skip to content

[improvements]: #33 mainly#38

Merged
javalsai merged 39 commits into
masterfrom
improvements
Jun 22, 2025
Merged

[improvements]: #33 mainly#38
javalsai merged 39 commits into
masterfrom
improvements

Conversation

@javalsai

@javalsai javalsai commented Jun 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner
  • several linter fixes
  • just smarter code in general
  • src/ui.c rewrite
  • dekstop parser and config parser unification (gotta push the changes but done)
  • better config parser
  • error logger
  • fully implement clang-tidy
  • integrate some sort of checks like valgrind (I don't think these will do for CI)
  • README formalization
  • check contribution guide
  • more allocation failure handling
  • support utf8 encoding properly
  • check manpage about config (document the timefmt string with man 3 strftime and add somewhere a reference to the possible function keys to be put)
  • write documentation on the code structure for contributions (nullability, formatting standard, dir structure, handling, logger, etc)

Maybe (likely not for v1.0.0):

  • TryExec
  • Standard parsing of Exec
  • Save last selection
  • Discuss possible IPC?
  • Show/hide passwd

Should also (future):

  • Add env for a custom timestampt (for screenshots mainly)

@javalsai

javalsai commented Jun 11, 2025

Copy link
Copy Markdown
Owner Author

NO WAY CHECKS ARE FINALLY RUNNING

@javalsai

javalsai commented Jun 12, 2025

Copy link
Copy Markdown
Owner Author

I'm happy to say that now the config parser fits in a single screen:

image

Oh, and new more toml like format (it's just parsing the same way as desktop files):
image

(I plan on quoting strings and allowing some escape sequences)

Now whitespace is also very flexible

@javalsai

javalsai commented Jun 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner Author

And config declaration is not that bad either, just macro'd tf out of it

image

EDIT: Gives rust-lang/rust/commit/0b1bbc5fd6cf477011f5a56ca0d978658a527db9 vibes lol.

@javalsai

javalsai commented Jun 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner Author

crazy

image
image

(just a git diff of 1200 lines)

@javalsai
feat: modernize config
5174f0b 
- config now is more toml like
- no need to declare all fields, it implements defaults
- no yanderedev code, introspection babbyyy 😎
- desktop and config files parser semi-unification
- misc tweaks all over (mainly allocation failures handling)
@javalsai

javalsai commented Jun 13, 2025

Copy link
Copy Markdown
Owner Author

I need to migrate all config files now 😭

@grialion

grialion commented Jun 13, 2025

Copy link
Copy Markdown
Collaborator

Can you stop spamming my email inbox? Thanks

@javalsai

javalsai commented Jun 13, 2025

Copy link
Copy Markdown
Owner Author

Can you stop spamming my email inbox? Thanks

Idk man, theres a pane on the right to unsubscribe notifs in the PR

@javalsai

javalsai commented Jun 15, 2025

Copy link
Copy Markdown
Owner Author

I think this will make v1.0.0

@javalsai

javalsai commented Jun 20, 2025

Copy link
Copy Markdown
Owner Author

image
😮‍💨

@javalsai javalsai force-pushed the improvements branch 2 times, most recently from 644d2fe to 906d336 Compare June 21, 2025 02:27
javalsai
javalsai commented Jun 21, 2025
View reviewed changes
Comment thread .gitignore
@javalsai javalsai marked this pull request as ready for review June 21, 2025 23:43
@javalsai

javalsai commented Jun 21, 2025

Copy link
Copy Markdown
Owner Author

@Pickzelle, this is ready, if you have some time and are bored you can check this and give some feedback or if not just approve please, releasing v1.0.0 tomorrow.

@javalsai javalsai requested a review from Pickzelle June 21, 2025 23:44
@javalsai javalsai self-assigned this Jun 21, 2025
@javalsai javalsai added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 21, 2025
@javalsai javalsai merged commit 2b1e469 into master Jun 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pickzelle Pickzelle Pickzelle approved these changes

Assignees

@javalsai javalsai

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@javalsai @grialion @Pickzelle @rmntgx