Add get_values_for_keys function to utils #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@camilonova and @Mogost , could you guys take a look? In my opinion it solves the issue, not inside the Config as mentioned, but definitely a use case that I would particularly appreciate to reduce database access. |
Natim
reviewed
Jan 13, 2025
Natim
reviewed
Jan 13, 2025
Contributor
|
The PR looks good to me, both comments are just nits |
Natim
reviewed
Jan 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #607 +/- ##
==========================================
+ Coverage 84.23% 84.67% +0.43%
==========================================
Files 21 21
Lines 736 744 +8
Branches 117 121 +4
==========================================
+ Hits 620 630 +10
+ Misses 83 82 -1
+ Partials 33 32 -1 ☔ View full report in Codecov by Sentry. |
Mogost
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #344.