Allow for user to provide custom esbuild config, attempt to use project's esbuild #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st). All tests passed.
…jest major version always goes together with Jest major version) from 26.6.3 to 27.4.7 (latest). All tests passed :D.
…sed. `yarn test` wont pass because it checks if all the code is pretty, but with the update, prettier wants to prettify it with it's new rules. That's why there is also a change in '.github/workflows/CI.yml': prettier will do it's job on the server side before one can accept any pull-request from now on.
jctaoo
approved these changes
Jan 31, 2022
Owner
|
I'll create a new release for some new features. Thanks for your works, and this PR may be a solution to jctaoo/vite-electron-esbuild-starter#53 |
Owner
|
It's included in 2.3.1 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great project.
We've made some updates to allow the user to provide a custom esbuild config file with the
--esbuild-config-fileoption - the default export is read and merged with the rest of the esbuild options.We also added an additional check to use the project's version of esbuild, if it exists, rather than electron-run's.
Please let me know if you'd like any additional changes or tweaks!