Conversation
jdx
added a commit
that referenced
this pull request
Mar 2, 2026
…ders CLI-based providers were using std::process::Command which blocks the tokio runtime thread, making buffer_unordered(10) effectively sequential. Switching to tokio::process::Command allows concurrent CLI execution, reducing N secrets from N*800ms to ~800ms. Fixes #8 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
jdx
added a commit
that referenced
this pull request
Mar 2, 2026
…ders (#308) ## Summary - Convert all 7 CLI-based providers from blocking `std::process::Command` to async `tokio::process::Command` - This allows `buffer_unordered(10)` in `get_secrets_concurrent()` to actually run CLI processes concurrently instead of blocking the tokio runtime thread - For N secrets at ~800ms per CLI call: sequential = N * 800ms → concurrent = ~800ms ## Providers changed | Provider | Key changes | |----------|-------------| | vault | `execute_vault_command` → async | | bitwarden | `execute_command` + build functions → async, return `tokio::process::Command` | | bitwarden-sm | `execute_bws_command` + `list_secrets` → async | | password-store | `execute_pass_command` → async, `put_secret` stdin → `tokio::io::AsyncWriteExt` | | proton-pass | `execute_pass_cli_command` → async | | 1password | `execute_op_command` + `execute_op_inject` → async, stdin → `tokio::io::AsyncWriteExt` | | infisical | `execute_infisical_command` → async (`get_auth_token` stays sync with explicit `std::process::Command` for Mutex-guarded login) | Fixes #8 ## Test plan - [x] `mise run build` passes - [x] `mise run test:cargo` passes (100/100 tests, 1 pre-existing keychain failure unrelated to changes) - [x] `mise run lint` passes (cargo-fmt, cargo-clippy, cargo-check all clean) - [ ] Manual testing with a Vault/1Password/etc provider to verify concurrent fetching 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches multiple secret-provider integrations and changes how external CLIs are spawned and awaited; failures would surface as auth/CLI errors or behavior differences under concurrency. > > **Overview** > Switches the CLI-driven providers (Bitwarden, Bitwarden Secrets Manager, 1Password, password-store, Proton Pass, Vault, and most of Infisical) from blocking `std::process::Command` to async `tokio::process::Command`, making `get_secret`/batch flows await process execution instead of blocking the runtime. > > Updates providers that write to child stdin (`op inject`, `pass insert`) to use async stdin writes/`wait_with_output().await`; Infisical keeps login token acquisition as a blocking `std::process::Command` under a mutex, while subsequent CLI calls are async. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 78d71aa. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.2.3 - 2025-10-20
🐛 Bug Fixes