[iOS] VoiceOver-only button to toggle player overlay #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LePips
requested changes
Sep 27, 2025
Member
LePips
left a comment
There was a problem hiding this comment.
Since this is mostly the start of introducing more complex accessibility elements, I'm going to think about how to do it foundationally so that we don't have to refactor it all in the future.
We shouldn't be introducing new accessibility_ functions just for it, but rather enhance the architectures (in this case, the video player). We may find that while working on accessibility features, it allows us to clean up the general case.
Contributor
Author
|
In terms of general accessibility elements, if I come up with some thoughts worth posting I'll put them in the Help Wanted discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1733
This adds an invisible voiceover-only button to the VideoPlayer which toggles the overlay and keeps it visible rather than fading it out in a couple seconds. I also simplified
setPlaybackControlsVisibilitysince I noticed some redundant ifs and stuff