fix: guard setTorrentsSequential against missing d.down.sequential.set#1113
Merged
Conversation
635d962 to
fb49ca7
Compare
Some rTorrent builds don't have the d.down.sequential method. The torrent list reading already handles this via getAvailableMethodCalls (replaces unavailable methods with false=). Add-torrent paths also had explicit guards, but since d.down.sequential and d.down.sequential.set are always supported together, those were redundant. This change: - Adds a guard in setTorrentsSequential (the only unguarded call site) - Removes the now-redundant isSequential checks from addTorrentsByFile and addTorrentsByURL - Removes the unused availableMethods variable from both add methods - Makes SEQUENTIAL_SET_METHOD a file-local constant in torrentPropertiesUtil
c5f0210 to
893cd3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some rTorrent builds do not have the d.down.sequential method. The torrent list reading and add-torrent paths already handle this by checking system.listMethods, but setTorrentsSequential was calling it unconditionally.
This PR adds the same availability check before issuing the RPC call and throws a clear error when the method is absent.
Also replaces the hardcoded string with the existing SEQUENTIAL_SET_METHOD constant for consistency.