Skip to content

fix: hex8 to rgba #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rkotov93 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: hex8 to rgba #30

rkotov93 wants to merge 1 commit into from

Conversation

@rkotov93
Copy link

@rkotov93 rkotov93 commented Apr 12, 2021 •
edited
Loading

Problem

Seems like currently Chroma::Color generates wrong RGB from HEX8. Here is a proof that #eb09b9c4 has to be 235, 9, 185:

Screenshot 2021-04-12 at 17 04 43 Screenshot 2021-04-12 at 19 21 22

But Chroma::Color#rgb returns 9, 185, 196:

Chroma::Color.new('#EB09B9C4').rgb
=> #<Chroma::ColorModes::Rgb:0x00007fac8de02a40 @a=0.9215686274509803, @b=196, @g=185, @r=9>

Solution:

I have found a six years old issue #6, that was resolved by replacing the order of arguments for FromHexStringValues#from_hex8 method. I have moved it back and now it returns expected RGB:

Chroma::Color.new('#EB09B9C4').rgb
=> #<Chroma::ColorModes::Rgb:0x00007fabb83d8e78 @a=0.7686274509803922, @b=185, @g=9, @r=235>

@rkotov93
Copy link
Author

rkotov93 commented May 20, 2021

Hey @jfairbank, is there any chance it will be merged?

@evanleck
Copy link

evanleck commented Sep 13, 2021

@rkotov93 FYI I've created a fork/rename of Chroma that I intend to maintain and I've fixed this issue with commit evanleck/kodachroma@b7df429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rkotov93 @evanleck