feat: add ETag support for mermaid.min.js #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds ETag caching support for the bundled Mermaid JavaScript library to reduce bandwidth usage. The ETag is generated from a content hash at startup and enables HTTP conditional requests.
- Implements ETag generation using a hash of the Mermaid.js content
- Adds HTTP conditional request handling with If-None-Match header support
- Updates cache control headers to use "public, no-cache" for proper revalidation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/app.rs | Implements ETag generation, conditional request handling, and updated response headers for mermaid.min.js |
| tests/integration_test.rs | Adds comprehensive test coverage for ETag caching behavior including 200, 304, and conditional request scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Add ETag caching to reduce bandwidth when serving the bundled Mermaid library. ETags are generated from the cargo version at startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ETag caching to reduce bandwidth when serving the bundled Mermaid library. ETags are generated from the crate version at startup.