Enable HTML tag rendering in markdown files #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50a7730 to
bd82d62
Compare
HTML tags were being escaped instead of rendered due to the markdown library's default security settings. This commit: - Consolidates markdown conversion logic to eliminate duplication - Enables allow_dangerous_html option for proper HTML rendering - Adds test coverage for HTML tag rendering behavior
bd82d62 to
5535b53
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables HTML tag rendering in markdown files by configuring the markdown parser to allow dangerous HTML instead of escaping it by default. The changes consolidate markdown conversion logic and add comprehensive test coverage.
- Consolidates duplicate markdown conversion code into a single method
- Enables
allow_dangerous_htmloption in markdown parser configuration - Adds integration test to verify HTML tags are rendered rather than escaped
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app.rs | Refactors markdown conversion to use centralized method with HTML rendering enabled |
| tests/integration_test.rs | Adds comprehensive test coverage for HTML tag rendering behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML tags were being escaped instead of rendered due to the markdown library's default security settings. This commit: