Docx writer: use namespace URI instead of prefix in extractPageLayout#11703
Merged
Conversation
When a reference document uses a non-standard namespace prefix for the WordprocessingML namespace (e.g. ns0 instead of w), sectPr elements copied from the reference would retain the non-w prefix, producing malformed XML in the output document. Similarly, extractPageLayout only matched elements with prefix "w", missing sectPr elements with other prefixes. Fix by matching on the namespace URI rather than the prefix, and normalize the prefix to "w" on all elements and attributes copied from reference-doc sectPr.
Owner
|
sorry, I didn't notice the test failures before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to PR with same title to fix tests failing