Skip to content

Use docker compose instead of docker-compose in container-setup script#603

Open
Blank-FS wants to merge 8 commits into
jikan-me:masterfrom
Blank-FS:master
Open

Use docker compose instead of docker-compose in container-setup script#603
Blank-FS wants to merge 8 commits into
jikan-me:masterfrom
Blank-FS:master

Conversation

@Blank-FS

Copy link
Copy Markdown

Changes container-setup script to use docker compose instead of docker-compose.

  • docker compose (with a space) is the modern, supported version (Compose V2)
  • docker-compose (with a hyphen) is the legacy, deprecated version (Compose V1)

Newer developers will typically have docker compose installed.

@Blank-FS Blank-FS requested a review from a team as a code owner June 10, 2026 11:58
@pushrbx pushrbx self-assigned this Jun 11, 2026
Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated
@Blank-FS

Copy link
Copy Markdown
Author

Sorry, mb! I originally only intended for the PR to be the 1st commit. The 2nd commit was for personal use for everything to work locally on my end, but I forgot to switch a branch.

  • You can ignore the changes made in the docker compose file, but the changes helped me run ./container-setup.sh start successfully.
  • Adding APP_URL=http://localhost:8080 to the env file resolved my issue with ./container-setup.sh execute-indexers failing to index, mainly because the original setup did not have a port number set.

Please lmk if any of these other changes could potentially be useful, otherwise you can just consider the 1st commit for the PR.

Thanks!

pushrbx added 2 commits June 13, 2026 06:26
`docker-compose` and `podman-compose` is obsolete since 2023, so those needed removing. The script didn't have correct error handling, so added it. Removed anti patterns too.
@pushrbx

pushrbx commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

I've also fixed the outstanding issues of the script here. Now it should work better with newer versions of docker and podman.

@pushrbx

pushrbx commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

I've given it a go locally again, found one more issue and fixed it. Please try it on your end and if it works this is ready to merge.

@Blank-FS

Blank-FS commented Jun 13, 2026

Copy link
Copy Markdown
Author

I tried it and found that set -euo pipefail caused the script to silently fail when I ran ./container-setup.sh start. It failed on the line podman_exists=$(command -v podman) - I don't have podman installed. Since the original version does not have set -euo pipefail, I have removed it.

Other than that, I was able get the script working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants