Various improvements around the container image distribution#385
Merged
pushrbx merged 14 commits intoOct 26, 2023
Conversation
Collaborator
pushrbx
commented
Jun 5, 2023
- Made the container image of Jikan API multi-arch. Supported architectures: amd64 and arm64 (tested on Ampere Altra cpus so far)
- Changed the container image release github action to do builds of different architectures in parallel
- Added support for container secrets
- Fixed docker-compose: now it should give you a production ready, single node, highly available deployment of Jikan API. However with room for tinkering. (E.g. default replica count is 1)
731bf91 to
e742699
Compare
fc4539a to
94d0753
Compare
94d0753 to
da364bc
Compare
- fixed cpu architecture - Removed unnecessary build args
ad4aed6 to
c615d65
Compare
irfan-dahir
reviewed
Oct 26, 2023
irfan-dahir
approved these changes
Oct 26, 2023
Contributor
irfan-dahir
left a comment
There was a problem hiding this comment.
@pushrbx Not a docker wiz but Lets Get This Merged 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.