Fix hang during rename-and-move in Zotero 6#594
Merged
Conversation
Resulting in not all annotations being transferred and the old attachment not being deleted Regression after zotero/zotero@734057ff9b, which added a transaction requirement to `Zotero.Items.moveChildItems()` but tried to preserve backwards compatibility with ZotFile. Unfortunately it had a bug, and a race condition with another transacation during the process results in a hang anyway if `moveChildItems()` isn't called in a transaction, so just change ZotFile to follow the new requirement. This also fixes `saveTx()` being called without an await. Fixes jlegewie#593
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, I broke things in zotero/zotero@734057ff9b.
Fixes #593