Always leave election when stopping #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR do?
So a couple of things were wrong in how the termination was happening. This PR adresses the following issues.
Fatal, which is a mistake because it does not honor the scheduleddeferintroducing a risk of not leaving the election. Never useFatalkids.This leads to much better failover time on graceful shutdowns
How to Test This PR?
Good PR Checklist