Ensure that tools/templates/prompts are compatible with callable objects #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves FastMCP’s support for callable objects by enhancing tests for tools, prompts, and resources that use both synchronous and asynchronous callable classes. It also updates the conversion logic in the from_function methods (in tool, prompt, and template modules) to better handle callable classes and introduces configuration changes for rich tracebacks in logging.
- Added thorough tests for callable objects and async callable objects.
- Updated from_function logic across modules to handle callable classes.
- Configured logging and settings to support rich tracebacks and added pytest-env configs.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/tools/test_tool_manager.py | New tests for callable and async callable objects in tool management. |
| tests/tools/test_tool.py | Added tests for callable objects in tools. |
| tests/server/test_server_interactions.py | Added tests for callable objects with context in tools, resources, and prompts. |
| tests/resources/test_resource_template.py | Added test illustrating callable objects used as resource templates. |
| tests/prompts/test_prompt_manager.py & test_prompt.py | Added tests for callable objects in prompt rendering. |
| src/fastmcp/utilities/logging.py | Updated logging configuration to leverage the enable_rich_tracebacks flag. |
| src/fastmcp/tools/tool.py | Updated from_function to support callable classes by extracting the call method. |
| src/fastmcp/settings.py | Introduced enable_rich_tracebacks configuration alongside log_level. |
| src/fastmcp/resources/template.py | Updated from_function to handle callable objects similarly to tools. |
| src/fastmcp/prompts/prompt.py | Updated from_function to extract callable objects’ call method. |
| pyproject.toml | Added pytest-env dependency and new environment variables for testing. |
jordicore
pushed a commit
to jordicore/fastmcp
that referenced
this pull request
Jul 2, 2025
Ensure that tools/templates/prompts are compatible with callable objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.