Skip to content

Fix URL-Encoding in Path applied twice#56

Merged
Haennetz merged 2 commits into
jmgilman:masterfrom
darkecho731:fix_double_url_encoding
Feb 24, 2024
Merged

Fix URL-Encoding in Path applied twice#56
Haennetz merged 2 commits into
jmgilman:masterfrom
darkecho731:fix_double_url_encoding

Conversation

@darkecho731

Copy link
Copy Markdown
Contributor

closes #55

Comment thread src/api.rs Outdated

@Haennetz Haennetz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your Fix, and sorry for the delayed review
I think the solution I provided would be more efficient then the current implementation, because we don't need to convert the path segments in new Vec.

Comment thread src/api.rs
Comment thread src/api.rs Outdated
Comment thread tests/kv2.rs Outdated
@Haennetz

Copy link
Copy Markdown
Collaborator

Also, please rebase your branch

@darkecho731 darkecho731 force-pushed the fix_double_url_encoding branch from f483efa to 6d0e877 Compare February 24, 2024 16:09
@darkecho731

Copy link
Copy Markdown
Contributor Author

Hi, I have implemented the proposed changes.

@Haennetz Haennetz merged commit 72375e6 into jmgilman:master Feb 24, 2024
@Haennetz

Copy link
Copy Markdown
Collaborator

Thanks the fix will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URL-Encoding in Path is applied twice

2 participants