Skip to content

Remove deprecated code from io.py#203

Merged
jni merged 1 commit into
jni:mainfrom
jamesyan-git:testdeps
Jun 1, 2023
Merged

Remove deprecated code from io.py#203
jni merged 1 commit into
jni:mainfrom
jamesyan-git:testdeps

Conversation

@jamesyan-git

Copy link
Copy Markdown
Contributor

Remove the use of pandas.save() (deprecated since pandas 1.5). pandas.close() is now sufficient to save and close a file.
I have also updated the setup.cfg to require pandas 2.0.2 (the latest release at the time of the PR).

@jamesyan-git

Copy link
Copy Markdown
Contributor Author

I cant seem to find any use of io.write_excel() outside of the tests though, so I'm a bit unsure how meaningfully test if it's behaving normally beyond that.

@jni

jni commented Jun 1, 2023

Copy link
Copy Markdown
Owner

Wow I just checked the test and it's pretty thorough, who wrote that 😂

Given the test I'm just going to merge this, thanks @jamesyan-git!

@jni jni merged commit 667ee63 into jni:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants