Mnt pickle test accross versions#1778
Open
Nanored4498 wants to merge 29 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
==========================================
+ Coverage 94.18% 95.26% +1.08%
==========================================
Files 46 46
Lines 7922 7927 +5
==========================================
+ Hits 7461 7552 +91
+ Misses 461 375 -86 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to remove pickle files from the repo. They are now generated in a github action job.
It seems that a non friendly error is thrown while reading a pickle file generated with python 2.7. I will investigate why.
Also, now, all test jobs needs the generation of pickle files to execute before.
Maybe it would be better, to just have one job generating and testing the compatibility with old pickle files?
Closes: #1776