Skip to content

person.py: updated codes for selenium and changed some class names in#158

Merged
joeyism merged 1 commit into
joeyism:masterfrom
lusifer021:master
May 10, 2023
Merged

person.py: updated codes for selenium and changed some class names in#158
joeyism merged 1 commit into
joeyism:masterfrom
lusifer021:master

Conversation

@lusifer021

Copy link
Copy Markdown
Contributor
  1. Changed some functions supporting selenium=4.8.3 and
  2. Also changed By.ID to By.TAG_NAME for accessing the main tag of experience and education page as these are changed by linkedin.
  3. Now it can parse multiple person profiles one after another.

@lusifer021 lusifer021 changed the title updated codes for selenium and changed some class names updated codes for selenium and changed some class names in person.py Apr 18, 2023
@lusifer021 lusifer021 changed the title updated codes for selenium and changed some class names in person.py person.py: updated codes for selenium and changed some class names in Apr 18, 2023
@ternaus

ternaus commented Apr 21, 2023

Copy link
Copy Markdown

This PR unblocks a lot of functionality.

Can anyone who has permissions merge it?

@lusifer021

Copy link
Copy Markdown
Contributor Author

@joeyism can you merge this PR? its working good

@aryamankha

Copy link
Copy Markdown

This PR is definitely a necessity - I'm using this branch to actually run the code. Heads up that searching By.CLASS_NAME for list_css doesn't work when you have connections working at the company (there's another list-style-none to show the images of people you know working there). Replacing that line with an XPATH match worked better for me:
results_list = driver.find_element(By.XPATH, "//ul[contains(@Class, 'list-style-none') and contains(@Class, 'flex-wrap') and contains(@Class, 'display-flex')]" )

@eleijonmarck

Copy link
Copy Markdown

@aryamankha how do you the scraper from pulling the repo locally?

@lusifer021

Copy link
Copy Markdown
Contributor Author
  1. Make a new environment, do not install linked_scraper in that.
  2. Clone the repo
  3. Just include these two lines in the starting of your code and write the path of the repo in it.
import sys
sys.path.append("/path/to/the/repo/")

@Sunishchal

Copy link
Copy Markdown

agree there is a breaking change with new selenium method names and my development is blocked until this PR is merged @joeyism 🙏

@aryamankha

Copy link
Copy Markdown

Linking forked version with this PR merged: https://github.com/aryamankha/linkedin_scraper

@joeyism joeyism merged commit b5731cb into joeyism:master May 10, 2023
@joeyism

joeyism commented May 10, 2023

Copy link
Copy Markdown
Owner

Sorry for the delay, this is released in 2.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants