Replace ostruct with a custom class that acts almost the same.#2106
Merged
Conversation
This removes a warning in 3.4.0 and prepares for Ruby 3.5.0: > warning: ostruct was loaded from the standard library, but will no longer > be part of the default gems since Ruby 3.5.0. Add ostruct to your Gemfile or gemspec. This seems preferable to adding ostruct as a gem dependency especially since older rubies may not support the gem version of ostruct.
Owner
Author
|
Honestly, not sure anyone uses FPM::RakeTask anymore. I was thinking about removing it, but the code to replace ostruct was fast enough to write that I'm not worried about deleting it right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a warning in 3.4.0 and prepares for Ruby 3.5.0; this warning only appeared when loading
lib/fpm/rake_task.rbThis seems preferable to adding ostruct as a gem dependency especially since older rubies may not support the gem version of ostruct.