Skip to content

uci: add cursor() flags argument#286

Merged
jow- merged 2 commits into
jow-:masterfrom
nbd168:uci
Apr 28, 2025
Merged

uci: add cursor() flags argument#286
jow- merged 2 commits into
jow-:masterfrom
nbd168:uci

Conversation

@nbd168

@nbd168 nbd168 commented Mar 22, 2025

Copy link
Copy Markdown
Contributor

This allows changing uci context parser flags. Primarily useful for disabling strict mode, which is enabled by default.

@jow-

jow- commented Apr 4, 2025

Copy link
Copy Markdown
Owner

Could you rename the function to just flags and make it return the currently effective flags if invoked without args (nargs == 0) ? Also I wonder if it makes sense to add a 4th flags argument to cursor(), I think most applications do not need to toggle flags once a cursor is instantiated so it seems more elegant to create it with the correct flags from the get-go

@nbd168 nbd168 changed the title uci: add cursor set_flags method uci: add cursor() flags argument Apr 6, 2025
@nbd168

nbd168 commented Apr 24, 2025

Copy link
Copy Markdown
Contributor Author

@jow- ping?

nbd168 added 2 commits April 28, 2025 11:18
Free the uci context

Signed-off-by: Felix Fietkau <nbd@nbd.name>
This allows changing uci context parser flags. Primarily useful for
disabling strict mode, which is enabled by default.

Signed-off-by: Felix Fietkau <nbd@nbd.name>
@jow- jow- merged commit 61ab5e6 into jow-:master Apr 28, 2025
@jow-

jow- commented Apr 28, 2025

Copy link
Copy Markdown
Owner

Merged, thanks!

@nbd168 nbd168 deleted the uci branch June 21, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants