cmd/run.go (1)

377-385: Consider updating verbose output to reflect prompt source.

The verbose output still shows Stdin: yes/no (line 385), but now that we have a --prompt flag, this could be slightly confusing. When -p is used, it might be clearer to show where the user message actually came from.

That said, this is pretty minor since verbose output goes to stderr and doesn't affect piped output. Feel free to defer if you'd like to keep this change focused.

💡 Optional enhancement for verbose clarity

-		stdinDisplay := "no"
-		if strings.TrimSpace(stdinContent) != "" {
-			stdinDisplay = "yes"
-		}
+		var msgSourceDisplay string
+		if strings.TrimSpace(promptFlag) != "" {
+			msgSourceDisplay = "-p flag"
+		} else if strings.TrimSpace(stdinContent) != "" {
+			msgSourceDisplay = "stdin"
+		} else {
+			msgSourceDisplay = "default"
+		}
 		_, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Model:    %s/%s\n", provName, modelName)
 		_, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Workdir:  %s\n", workdir)
 		_, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Skill:    %s\n", skillDisplay)
 		_, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Files:    %d file(s)\n", len(files))
-		_, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Stdin:    %s\n", stdinDisplay)
+		_, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Message:  %s\n", msgSourceDisplay)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cmd/run.go` around lines 377 - 385, Update the verbose output to show the
actual prompt source instead of only "Stdin: yes/no": compute a promptSource
string (e.g., "flag" when the --prompt/-p flag was used, "stdin" when
strings.TrimSpace(stdinContent) != "" and no flag, or "none"/"files" as
appropriate) and replace the current stdinDisplay usage in the fmt.Fprintf call
so the line prints something like "Prompt:   <promptSource>" while keeping the
existing lines that print provName, modelName, workdir, skillDisplay, and files;
use the existing symbols stdinContent, stdinDisplay (or replace it), provName,
modelName, workdir, skillDisplay, and files to locate and update the code.

cmd/smoke_test.go (1)

283-292: Consider extracting User Message section parsing into a tiny helper.

The section-slicing logic is duplicated and could get brittle if message content contains ---. A shared helper would make these tests easier to maintain (and less puzzle-like at 2am).

Also applies to: 371-380

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cmd/smoke_test.go` around lines 283 - 292, The section-slicing logic around
userMsgIdx/afterUserMsg/userMsgSection is duplicated and brittle; extract a
small helper (e.g., extractSection(stdout string, header string) string) used by
both occurrences to locate the header ("--- User Message ---"), return the
section up to the next "---" or the remainder, and replace the inline slicing in
the test with calls to that helper; ensure the helper trims/returns exactly the
same substring semantics as the current code so existing assertions need no
change.

cmd/run_test.go (1)

2928-2944: Prefer testutil mock helpers over ad-hoc HTTP mocks here.

This new test spins up a manual httptest mock. Using internal/testutil helpers would reduce boilerplate and align test style across the suite.

As per coding guidelines "No mocks in tests when avoidable — use the real thing or testutil helpers instead".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cmd/run_test.go` around lines 2928 - 2944, Replace the ad-hoc
httptest.NewServer usage in the test (the server variable, the inline
http.HandlerFunc, and receivedBody capture) with the internal/testutil HTTP mock
helper used across the repo: create a testutil mock server that returns the same
JSON response, sets Content-Type and status 200, and exposes a way to capture
the request body (replace uses of server and receivedBody with the helper's
equivalents), and ensure you call the helper's Close/Teardown in defer; keep the
response payload, headers and captured request body behavior identical to
preserve test assertions.