Attempt to clarify AugmentedInferenceAgreesWithBaseInference. #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still far from a full explanation, but it's less incorrect and slightly more informative. I hope.
netdpb
reviewed
Sep 15, 2022
| * Notice that `makeList(a, b)` is fine "in a vacuum" even under JSpecify (as shown above). Only | ||
| * here, where the type of the expression is forced to conform to the target type, is there a | ||
| * problem. | ||
| * here, where the type of the expression is forced to conform to the javac's type for the |
Collaborator
There was a problem hiding this comment.
It looks like the expression type is being forced to conform to JSpecify's preferred type. No?
netdpb
reviewed
Sep 15, 2022
| * Notice that `makeList(a, b)` is fine "in a vacuum" even under JSpecify (as shown above). Only | ||
| * here, where the type of the expression is forced to conform to the target type, is there a | ||
| * problem. | ||
| * here, where the type of the expression is forced to conform to the javac's type for the |
Collaborator
There was a problem hiding this comment.
Suggested change
| * here, where the type of the expression is forced to conform to the javac's type for the | |
| * here, where the type of the expression is forced to conform to javac's type for the |
Collaborator
|
Just keep noticing this hanging around in our PRs tab. No biggie but here's a bump if you wanted one. |
Collaborator
|
@cpovirk, do you want to look at this again and close it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still far from a full explanation, but it's less incorrect and
slightly more informative. I hope.