x64環境でmp3infp_cplが起動しない・クラッシュする#7
Merged
Merged
Conversation
LPARAM parameter in callback function was defined as LONG.
k-takata
added a commit
that referenced
this pull request
Feb 11, 2014
x64環境でmp3infp_cplが起動しない・クラッシュする
Owner
|
ありがとうございます。 |
k-takata
added a commit
that referenced
this pull request
May 2, 2016
・libogg 1.3.2, libvorbis 1.3.5 に更新。 ・mp4v2 2.0.0 (r507) に更新。 ・x64 で mp3infp.cpl がクラッシュするのを修正。(PR #7, Thanks unarist) ・mp3infp.cpl を High DPI に対応。 ・コンパイラを WDK 7.1.0 に変更。 ・Windows Vista 以前をサポート対象から除外。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
コールバック関数の定義でLPARAMの代わりにLONGが使われていたために、アクセス違反で落ちていたようです。
またこちらは致命的ではありませんが、周辺で使われている型も確認して、キャストや定義の変更を行いました。