Skip to content

Expand docker upgrade test, sunset E2E upgrade test #13338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dereknola wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Expand docker upgrade test, sunset E2E upgrade test #13338

dereknola wants to merge 2 commits into from

Conversation

@dereknola
Copy link
Member

@dereknola dereknola commented Dec 12, 2025 •
edited
Loading

Proposed Changes

  • The E2E upgrade is too big to run on GHA runners (and thus was run on the old Drone CI runners). With Drone dead, we need to migrate this coverage to another test.
  • Move the upgrade testlets to the from the E2E version to the Docker version.
  • Increase the number of servers for the docker version from 1 to 3, matching the E2E upgrade cluster test in number of nodes.

Types of Changes

CI improvement

Verification

CI is still green, test passes. Test takes ~4min compared to the previous ~2.5m, but thats still alot better than the E2E upgrade test of ~7 to 10m.

Testing

All Testing

Linked Issues

N/A

User-Facing Change

Further Comments

@dereknola dereknola requested a review from a team as a code owner December 12, 2025 18:27
@codecov
Copy link

codecov bot commented Dec 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.41%. Comparing base (c0b1314) to head (c6e48de).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13338      +/-   ##
==========================================
- Coverage   21.42%   21.41%   -0.01%     
==========================================
  Files         187      187              
  Lines       15296    15296              
==========================================
- Hits         3277     3276       -1     
- Misses      11573    11574       +1     
  Partials      446      446
Flag Coverage Δ
unittests 21.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

brandond
brandond reviewed Dec 12, 2025
View reviewed changes
@dereknola
Expand docker upgrade test, sunset E2E upgrade test
d98dafa 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
Replace legacy ReplicationController with Deployment
c6e48de 
Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandond brandond brandond left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dereknola @brandond