Skip to content

chore(virtiofs): Drop feature gate EnableVirtioFsConfigVolumes #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jcanocan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(virtiofs): Drop feature gate EnableVirtioFsConfigVolumes #937

jcanocan wants to merge 1 commit into from

Conversation

@jcanocan
Copy link
Contributor

@jcanocan jcanocan commented Oct 21, 2025

What this PR does / why we need it:

The feature has been graduated to GA. Therefore, the usage of the feature gate is not longer required to share configmaps, secrets, serviceAccounts or DownwardAPI with virtiofs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

Remove `EnableVirtioFsConfigVolumes` feature gate references.

@jcanocan @germag
chore(virtiofs): Drop feature gate EnableVirtioFsConfigVolumes
d799e02 
The feature has been graduated to GA. Therefore, the usage of the
feature gate is not longer required to share configmaps, secrets,
serviceAccounts or DownwardAPI with virtiofs.

Co-authored-by: German Maglione <gmaglione@redhat.com>
Signed-off-by: Javier Cano Cano <jcanocan@redhat.com>
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Oct 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 21, 2025
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mhenriks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@germag germag mentioned this pull request Oct 21, 2025
Open
4 tasks
@jcanocan jcanocan marked this pull request as ready for review December 2, 2025 08:30
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2025
@germag
Copy link

germag commented Dec 2, 2025

The Graduation of EnableVirtioFsConfigVolumes feature gate has been merged

@germag
Copy link

germag commented Dec 2, 2025

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Dec 9, 2025

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Dec 9, 2025
@jcanocan
Copy link
Contributor Author

jcanocan commented Dec 19, 2025

@aburdenthehand could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awels awels Awaiting requested review from awels

@ShellyKa13 ShellyKa13 Awaiting requested review from ShellyKa13

Assignees

@germag germag

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-approver-review Indicates that a PR requires a review from an approver. size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jcanocan @kubevirt-bot @germag