Skip to content

Conversation

@Cedric-Lefebvre
Copy link
Contributor

Release Notes Headline

Fix: frontend.service.type was ignored when set.

Commentary for Reviewers

The template always rendered ClusterIP. The fix makes the chart correctly use the value provided by the user.

Links to Issues or Tickets

N/A

User Impact and Risks

Users can now set frontend.service.type and get the expected result.
Very low risk.

Testing

helm template .  --set frontend.service.type=NodePort -s templates/frontend/frontend-service.yaml

The output now correctly shows type: NodePort.

Documentation Updates

N/A

Copy link
Collaborator

@jessegoodier jessegoodier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jessegoodier jessegoodier added v3.0 bug Something isn't working cherry-pick labels Nov 19, 2025
@jessegoodier jessegoodier enabled auto-merge (squash) November 19, 2025 02:32
@jessegoodier jessegoodier merged commit cb6cdcc into kubecost:develop Nov 19, 2025
10 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 19, 2025
@github-actions
Copy link

Successfully created backport PR for v3.0:

@Cedric-Lefebvre Cedric-Lefebvre deleted the fix-frontend-service-type branch November 19, 2025 02:36
jessegoodier pushed a commit that referenced this pull request Nov 19, 2025
(cherry picked from commit cb6cdcc)

Co-authored-by: Cédric Lefebvre <Cedric-Lefebvre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cherry-pick v3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants