Skip to content
This repository was archived by the owner on Sep 12, 2023. It is now read-only.

change type of rtype to commonv1.ReplicaType #135

Merged
google-oss-robot merged 1 commit into from
Jun 1, 2021
Merged

change type of rtype to commonv1.ReplicaType #135

google-oss-robot merged 1 commit into from
Jun 1, 2021

Conversation

@MartinForReal
Copy link
Member

@MartinForReal MartinForReal commented May 25, 2021

related: #134

@MartinForReal
Copy link
Member Author

MartinForReal commented May 25, 2021

/assign @terrytangyuan

gaocegege
gaocegege reviewed May 25, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @terrytangyuan @zw0610 @carmark @Jeffwan

@carmark
Copy link
Member

carmark commented May 25, 2021

Did you do gofmt?

@MartinForReal
Copy link
Member Author

MartinForReal commented May 25, 2021

Did you do gofmt?

Please refer to https://travis-ci.com/github/kubeflow/common/builds/226788990

terrytangyuan
terrytangyuan reviewed May 25, 2021
View reviewed changes
@terrytangyuan terrytangyuan linked an issue May 25, 2021 that may be closed by this pull request
Type of replicaType is not consistent in common project #134
Closed
terrytangyuan
terrytangyuan reviewed May 26, 2021
View reviewed changes
terrytangyuan
terrytangyuan reviewed May 26, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Others PTAL.

@Jeffwan
Copy link
Member

Jeffwan commented May 27, 2021

common/pkg/apis/common/v1/types.go

Line 151 in eb55dde

type RestartPolicy string

Nice catch. ReplicaType is string and we may forget to make them consistent. This will be a user facing change and operators will need to make corresponding change after upgrade.

/lgtm

@Jeffwan
Copy link
Member

Jeffwan commented Jun 1, 2021

/approve

@google-oss-robot google-oss-robot merged commit 31efa75 into kubeflow:master Jun 1, 2021
@google-oss-robot
Copy link

google-oss-robot commented Jun 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan Jeffwan mentioned this pull request Aug 30, 2021
Closed
Jeffwan added a commit to Jeffwan/common that referenced this pull request Aug 30, 2021
@Jeffwan
Revert kubeflow#135: change rtype to commonv1.ReplicaType
7125957 
kubeflow#135 This change brings some extra side effects and make training operator dependency upgrade fail. Since this change is kind of refactor, we determine to revert it at this moment.
@Jeffwan Jeffwan mentioned this pull request Aug 30, 2021
Merged
google-oss-robot pushed a commit that referenced this pull request Aug 30, 2021
@Jeffwan
Revert #135: change rtype to commonv1.ReplicaType (#158)
654b666 
#135 This change brings some extra side effects and make training operator dependency upgrade fail. Since this change is kind of refactor, we determine to revert it at this moment.
Jeffwan added a commit to Jeffwan/common that referenced this pull request Sep 19, 2021
@Jeffwan
Revert kubeflow#135: change rtype to commonv1.ReplicaType
d9461e2 
Since reconciler.v1 add more changes. This revert's scope is larger than original PR.

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Jeffwan added a commit to Jeffwan/common that referenced this pull request Sep 19, 2021
@Jeffwan
Revert kubeflow#135: change rtype to commonv1.ReplicaType
fa99a6e 
Since reconciler.v1 add more changes. This revert's scope is larger than original PR.

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Jeffwan added a commit to Jeffwan/common that referenced this pull request Sep 20, 2021
@Jeffwan
Revert kubeflow#135: change rtype to commonv1.ReplicaType
070e195 
Since reconciler.v1 add more changes. This revert's scope is larger than original PR.

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
gaocegege pushed a commit to gaocegege/common that referenced this pull request Nov 23, 2021
@Jeffwan @gaocegege
Revert kubeflow#135: change rtype to commonv1.ReplicaType (kubeflow#158)
def4f33 
kubeflow#135 This change brings some extra side effects and make training operator dependency upgrade fail. Since this change is kind of refactor, we determine to revert it at this moment.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@gaocegege gaocegege gaocegege left review comments

@Jeffwan Jeffwan Jeffwan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@terrytangyuan terrytangyuan

@Jeffwan Jeffwan

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type of replicaType is not consistent in common project

6 participants

@MartinForReal @carmark @Jeffwan @google-oss-robot @terrytangyuan @gaocegege