-
Notifications
You must be signed in to change notification settings - Fork 41.6k
Open
Labels
lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one.Indicates an issue or PR lacks a `sig/foo` label and requires one.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Description
When making an API change, there are some basic mechanical changes as well as auto-generated changes in various components that currently do not have API approver permissions.
We should consider expanding ownership coverage and/or refactoring the files in question such that we can separate out the mechanical changes as part of making an API change with changes that would require deep expertise.
Example PR of API promotion from beta to GA: #131549. The components that needed additional approval were:
cmd/kube-controller-manager: specific people
pkg/printers; sig-cli-approvers
plugin/pkg/auth/authorizer: sig-auth-approvers
staging/src/k8s.io/client-go: sig-api-machinery
staging/src/k8s.io/kubectl; sig-cli-approvers
Metadata
Metadata
Assignees
Labels
lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one.Indicates an issue or PR lacks a `sig/foo` label and requires one.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.