Skip to content

[Kep-3751] Promote VolumeAttributesClass to GA #131549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

[Kep-3751] Promote VolumeAttributesClass to GA #131549

merged 1 commit into from
Jul 24, 2025

Conversation

@carlory
Copy link
Member

@carlory carlory commented Apr 30, 2025 •
edited
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

GA graduation criteria:

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#3751

Special notes for your reviewer:

/hold

util Beta graduation criteria is met

Does this PR introduce a user-facing change?

- Promoted feature-gate `VolumeAttributesClass` to GA
- Promoted API `VolumeAttributesClass` and `VolumeAttributesClassList` to `storage.k8s.io/v1`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:  https://github.com/kubernetes/enhancements/issues/3751

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/kubectl area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 30, 2025
@k8s-ci-robot k8s-ci-robot added sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Apr 30, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Apr 30, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Apr 30, 2025
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Apr 30, 2025
@carlory
Copy link
Member Author

carlory commented Apr 30, 2025

/cc @sunnylovestiramisu @gnufied @AndrewSirenko @jsafrane @msau42

@carlory
Promoted API VolumeAttributesClass and VolumeAttributesClassList …
94bf8fc 
…to `storage.k8s.io/v1`.

Promoted feature-gate `VolumeAttributesClass` to GA (on by default)

Signed-off-by: carlory <baofa.fan@daocloud.io>
@carlory
Copy link
Member Author

carlory commented Jul 24, 2025

unrelated failure
/test pull-kubernetes-conformance-kind-ga-only-parallel

@carlory
Copy link
Member Author

carlory commented Jul 24, 2025

/retest-required

@sunnylovestiramisu
Copy link
Contributor

sunnylovestiramisu commented Jul 24, 2025

/test pull-kubernetes-e2e-storage-kind-vac

@msau42
Copy link
Member

msau42 commented Jul 24, 2025

For this enhancement, we have only one feature gate named VolumeAttributesClass. In this PR, we promote it to GA, but the sidecar need to be updated after 1.34 is released. So a part of the feature's e2e tests depends on the beta api.

I see .... that feels kinda broken. For example we wouldn't allow that to become a conformance test.

For clarity, the API conformance tests are here and they are fine being promoted to GA as they don't have an external dependency (the csi driver): test/e2e/storage/volumeattributesclass.go

It's the csi e2e tests that have the external dependency on the beta API and needs a release with the v1 API once it's available.

We discussed offline and agreed that adding a feature label is the most feasible way to deal with this dependency atm.

@msau42
Copy link
Member

msau42 commented Jul 24, 2025

/approve
Waiting for the new test job to pass before final lgtm

@msau42
Copy link
Member

msau42 commented Jul 24, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 24, 2025

LGTM label has been added.

Git tree hash: dc4d931a7ecfdb13fb9648ce3a4e5180ac10c991

@liggitt liggitt moved this from Assigned to API review completed, 1.34 in API Reviews Jul 24, 2025
jpbetz
jpbetz approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
For API Machinery bits. Nothing surprising there.

@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 24, 2025

/approve

For the rest (esp printers)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jpbetz, msau42, smarterclayton, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2025
@sunnylovestiramisu
Copy link
Contributor

sunnylovestiramisu commented Jul 24, 2025

Got all the approvals
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@msau42 msau42 mentioned this pull request Jul 24, 2025
Open
@xing-yang
Copy link
Contributor

xing-yang commented Jul 24, 2025

/test pull-kubernetes-integration

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 24, 2025

@carlory: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-apidiff-client-go 94bf8fc link false /test pull-kubernetes-apidiff-client-go
pull-kubernetes-integration 94bf8fc link true /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sunnylovestiramisu
Copy link
Contributor

sunnylovestiramisu commented Jul 24, 2025 •
edited
Loading

/retest-required

The failed tests are related to TestNominatedNodeCleanUp which is not related to VAC.

@k8s-ci-robot k8s-ci-robot merged commit 7912e5f into kubernetes:master Jul 24, 2025
19 of 21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 24, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG CLI Jul 24, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Jul 24, 2025
@github-project-automation github-project-automation bot moved this from In Review to Closed / Done in SIG Auth Jul 24, 2025
@carlory carlory deleted the KEP-3751-GA branch July 25, 2025 03:47
spowelljr
spowelljr reviewed Jul 25, 2025
View reviewed changes
staging/src/k8s.io/api/storage/v1alpha1/types.go

// +k8s:prerelease-lifecycle-gen:introduced=1.29
// +k8s:prerelease-lifecycle-gen:deprecated=1.32
// +k8s:prerelease-lifecycle-gen:replacement=storage.k8s.io,v1,VolumeAttributesClass
Copy link
Member

@spowelljr spowelljr Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is setting VolumeAttributesClass as the replacement for VolumeAttributesClassList, just checking if this was meant to be added to VolumeAttributesClass instead?

Copy link
Member Author

@carlory carlory Jul 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your report. #133244 will fix it.

@dims dims mentioned this pull request Aug 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@brianpursley brianpursley Awaiting requested review from brianpursley

@deads2k deads2k Awaiting requested review from deads2k

@AndrewSirenko AndrewSirenko Awaiting requested review from AndrewSirenko

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

@liggitt liggitt Awaiting requested review from liggitt

@mattcary mattcary Awaiting requested review from mattcary

@xing-yang xing-yang Awaiting requested review from xing-yang

@msau42 msau42 Awaiting requested review from msau42

+6 more reviewers

@pohly pohly pohly left review comments

@andyzhangx andyzhangx andyzhangx left review comments

@spowelljr spowelljr spowelljr left review comments

@jpbetz jpbetz jpbetz approved these changes

@stlaz stlaz stlaz approved these changes

@hashim21223445 hashim21223445 hashim21223445 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stlaz stlaz

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

API Reviews
Status: API review completed, 1.34
SIG Apps
Archived in project
SIG Auth
Archived in project
SIG CLI
Archived in project

Milestone

v1.34

Development

Successfully merging this pull request may close these issues.